Deprecate cudf::grouped_time_range_rolling_window#17589
Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.02from Jan 20, 2025
Merged
Deprecate cudf::grouped_time_range_rolling_window#17589rapids-bot[bot] merged 4 commits intorapidsai:branch-25.02from
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.02from
Conversation
wence-
added
improvement
Contributor
|
Thank you, @wence-. I've been dragging my feet on this one. I have checked. It appears that I've already removed references to the time-range version of these calls from the Java API, and switched it to numeric ranges.
This is looking good to go. |
Contributor
|
The failures seem to be transient and unrelated to the change. I've restarted the failing CI jobs. |
wence-
force-pushed
the
wence/fea/rolling-deprecate
branch
2 times, most recently
from
6e6b5b4 to
3bb751d
Compare
Since the range-based rolling window APIs were extended to support any orderable column (rather than just time-based windows), this function has been a thin forwarding wrapper to cudf::grouped_range_rolling_window. It could have been deprecated at the time, but was not. It seems there are no usages outside of the libcudf test suite. Partially addresses rapidsai#13050.
wence-
force-pushed
the
wence/fea/rolling-deprecate
branch
from
3bb751d to
f5366e5
Compare
bdice
approved these changes
Jan 20, 2025
lamarrr
approved these changes
Jan 20, 2025
Contributor
lamarrr
left a comment
lamarrr
left a comment
There was a problem hiding this comment.
LGTM. thanks for working on this!
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since the range-based rolling window APIs were extended to support any orderable column (rather than just time-based windows), this function has been a thin forwarding wrapper to
cudf::grouped_range_rolling_window. It could have been deprecated at the time, but was not. It seems there are no usages outside of the libcudf test suite.
Partially addresses #13050.
Checklist